Allow float center for rotate operations#8114
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Jun 25, 2024
Merged
Conversation
hugovk
approved these changes
Jun 25, 2024
Member
hugovk
left a comment
There was a problem hiding this comment.
Only a seven-year-old FIXME :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
im.rotate(), there isPillow/src/PIL/Image.py
Lines 2375 to 2379 in 5bacce9
Looking through the code after that, there is no reason why they can't be floats - the numbers are simply combined with other floats.
Pillow/src/PIL/Image.py
Lines 2381 to 2399 in 5bacce9
This also allows the rotation center to be the exact center of an image with odd dimensions - although that also sound like a good argument why the user might want to pass in floats as the
center, so I've updated the type hint accordingly.