Do not use first frame duration for other frames when saving APNG images#8104
Merged
hugovk merged 2 commits intopython-pillow:mainfrom Jun 25, 2024
Merged
Do not use first frame duration for other frames when saving APNG images#8104hugovk merged 2 commits intopython-pillow:mainfrom
hugovk merged 2 commits intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8102
When saving APNG images, if there is no
durationargument given to thesave()command, thendurationis pulled from the first image'sinfodictionary.Pillow/src/PIL/PngImagePlugin.py
Lines 1107 to 1108 in 1794a94
That value is later re-used for subsequent frames, leading to the unexpected behaviour in the issue.
Pillow/src/PIL/PngImagePlugin.py
Lines 1170 to 1171 in 1794a94
This PR corrects this, using GifImagePlugin's
_write_multiple_frames()as a model.