Merged
Conversation
hugovk
reviewed
Jun 3, 2024
pyproject.toml
Outdated
| ] | ||
| [project.optional-dependencies] | ||
| docs = [ | ||
| optional-dependencies.docs = [ |
Member
There was a problem hiding this comment.
pyproject-fmt version 2 has a fairly big change here, reformatting these from "expanded" to "inline".
I slightly prefer the old version, but am not too bothered really.
There's a chance pyproject-fmt might add an option to retain the old version. We could revert these changes for now, see if it's added by the next monthly autoupdate.
What do others think?
Member
There was a problem hiding this comment.
I agree that the old version is neater.
If this is just how things are with the latest version, that's fine.
If you think we're just going to revert this change in a month though, I'd rather keep it as it is for now than confusing the blame for this file.
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.3 → v0.4.7](astral-sh/ruff-pre-commit@v0.4.3...v0.4.7) - [github.com/pre-commit/mirrors-clang-format: v18.1.4 → v18.1.5](pre-commit/mirrors-clang-format@v18.1.4...v18.1.5) - [github.com/python-jsonschema/check-jsonschema: 0.28.2 → 0.28.4](python-jsonschema/check-jsonschema@0.28.2...0.28.4) - [github.com/abravalheri/validate-pyproject: v0.16 → v0.18](abravalheri/validate-pyproject@v0.16...v0.18)
e10b711 to
322814d
Compare
hugovk
approved these changes
Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: