When saving multiple PNG frames, convert to mode rather than raw mode by radarhere · Pull Request #8087 · python-pillow/Pillow

radarhere · 2024-05-27T07:37:44Z

Resolves #8081

The issue points out that _write_multiple_frames converts images to rawmode

Pillow/src/PIL/PngImagePlugin.py

Line 1125 in bbe1eff

im_frame = im_frame.convert(rawmode)

where rawmode is

Pillow/src/PIL/PngImagePlugin.py

Line 1297 in bbe1eff

rawmode, bit_depth, color_type = _OUTMODES[mode]

Pillow/src/PIL/PngImagePlugin.py

Lines 1052 to 1069 in bbe1eff

    
           _OUTMODES = { 
        
               # supported PIL modes, and corresponding rawmode, bit depth and color type 
        
               "1": ("1", b"\x01", b"\x00"), 
        
               "L;1": ("L;1", b"\x01", b"\x00"), 
        
               "L;2": ("L;2", b"\x02", b"\x00"), 
        
               "L;4": ("L;4", b"\x04", b"\x00"), 
        
               "L": ("L", b"\x08", b"\x00"), 
        
               "LA": ("LA", b"\x08", b"\x04"), 
        
               "I": ("I;16B", b"\x10", b"\x00"), 
        
               "I;16": ("I;16B", b"\x10", b"\x00"), 
        
               "I;16B": ("I;16B", b"\x10", b"\x00"), 
        
               "P;1": ("P;1", b"\x01", b"\x03"), 
        
               "P;2": ("P;2", b"\x02", b"\x03"), 
        
               "P;4": ("P;4", b"\x04", b"\x03"), 
        
               "P": ("P", b"\x08", b"\x03"), 
        
               "RGB": ("RGB", b"\x08", b"\x02"), 
        
               "RGBA": ("RGBA", b"\x08", b"\x06"), 
        
           }

and so may not always be a Pillow image mode.

radarhere mentioned this pull request May 27, 2024

Saving all frames of a paletted PNG with few colors can fail #8081

Closed

When saving multiple frames, convert to mode rather than raw mode

f34360d

radarhere force-pushed the png_save_all branch from 47479fa to f34360d Compare May 27, 2024 08:30

hugovk merged commit 48a921b into python-pillow:main Jun 25, 2024

radarhere deleted the png_save_all branch June 25, 2024 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

When saving multiple PNG frames, convert to mode rather than raw mode#8087

When saving multiple PNG frames, convert to mode rather than raw mode#8087
hugovk merged 1 commit intopython-pillow:mainfrom
radarhere:png_save_all

radarhere commented May 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	_OUTMODES = {
	# supported PIL modes, and corresponding rawmode, bit depth and color type
	"1": ("1", b"\x01", b"\x00"),
	"L;1": ("L;1", b"\x01", b"\x00"),
	"L;2": ("L;2", b"\x02", b"\x00"),
	"L;4": ("L;4", b"\x04", b"\x00"),
	"L": ("L", b"\x08", b"\x00"),
	"LA": ("LA", b"\x08", b"\x04"),
	"I": ("I;16B", b"\x10", b"\x00"),
	"I;16": ("I;16B", b"\x10", b"\x00"),
	"I;16B": ("I;16B", b"\x10", b"\x00"),
	"P;1": ("P;1", b"\x01", b"\x03"),
	"P;2": ("P;2", b"\x02", b"\x03"),
	"P;4": ("P;4", b"\x04", b"\x03"),
	"P": ("P", b"\x08", b"\x03"),
	"RGB": ("RGB", b"\x08", b"\x02"),
	"RGBA": ("RGBA", b"\x08", b"\x06"),
	}

Uh oh!

Conversation

radarhere commented May 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants