winbuild: Refactor dependency versions into constants#7843
Merged
radarhere merged 9 commits intopython-pillow:mainfrom Mar 9, 2024
Merged
winbuild: Refactor dependency versions into constants#7843radarhere merged 9 commits intopython-pillow:mainfrom
radarhere merged 9 commits intopython-pillow:mainfrom
Conversation
nulano
reviewed
Mar 2, 2024
Contributor
nulano
left a comment
There was a problem hiding this comment.
Looks good.
Two suggestions:
- Do we also want
V['libimagequant']for consistency? - I would also include
SF_PROJECTSin the format strings now that it's not the only variable. IIRC it was done with a plus operator because it was the same length, but now it saves one character :).
Co-authored-by: Ondrej Baranovič <ondreko.tiba@gmail.com>
Member
Author
Yes, but let's do it when we're no longer pointing to a Git hash: Pillow/winbuild/build_prepare.py Lines 324 to 344 in 1b7bcfb
Good idea, suggestions applied! |
Member
Author
|
I've added a couple more commits to silence IDE (PyCharm) squiggly warnings. |
radarhere
reviewed
Mar 5, 2024
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
reviewed
Mar 7, 2024
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
reviewed
Mar 7, 2024
radarhere
reviewed
Mar 7, 2024
radarhere
reviewed
Mar 7, 2024
radarhere
approved these changes
Mar 8, 2024
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
__main__calls intomain()to avoid shadowing variablesSee also the last commit, I first put them as separate constants like:
I then refactored that into a single dict:
So we can refer to them like
V['BROTLI']instead ofBROTLI_VERSION, but I'm not sure which I prefer.Thoughts?
cc @nulano