Use consistent arguments for load_read and load_seek#7713
Merged
hugovk merged 2 commits intopython-pillow:mainfrom Mar 11, 2024
Merged
Use consistent arguments for load_read and load_seek#7713hugovk merged 2 commits intopython-pillow:mainfrom
hugovk merged 2 commits intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_read()does not have a consistent signature across the plugins where it is used. For example,Pillow/src/PIL/JpegImagePlugin.py
Line 411 in 9923531
Pillow/src/PIL/XpmImagePlugin.py
Line 106 in 9923531
Neither does
load_seek(). For example,Pillow/src/PIL/FtexImagePlugin.py
Line 105 in 9923531
Pillow/src/PIL/IcoImagePlugin.py
Line 342 in 9923531