Replaced deprecated Py_FileSystemDefaultEncoding for Python >= 3.12#7192
Merged
hugovk merged 1 commit intopython-pillow:mainfrom May 29, 2023
Merged
Replaced deprecated Py_FileSystemDefaultEncoding for Python >= 3.12#7192hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
hugovk
reviewed
May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #6941.
Python 3.12 reports a deprecation - https://github.com/python-pillow/Pillow/actions/runs/5105776867/jobs/9177570491#step:7:234
https://docs.python.org/3.12/whatsnew/3.12.html#id4 instructs us to replace it with
PyConfig.filesystem_encoding.Using https://docs.python.org/3.12/c-api/init_config.html#example as a basis, I made that change.
However, I found this failed on PyPy, with
I asked in https://foss.heptapod.net/pypy/pypy/-/issues/3946, and PyPy has chosen not to implement PyConfig yet. So I've switched to the new code only for Python 3.12 and later, and we can see what happens once PyPy does support Python 3.12.