Fixed calling putpalette() on L and LA images before load()#7187
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Jun 13, 2023
Merged
Fixed calling putpalette() on L and LA images before load()#7187hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the problem raised in #7186
putpalette()'s strategy for attaching a palette to an image is to change the mode, set the palette, and then callload().Pillow/src/PIL/Image.py
Lines 1918 to 1921 in 117618b
We have been testing this with all of the valid modes.
However, the user found an error when calling
putpalette()on an image directly after opening it, beforeload()is called. This means that L and LA images are attempted to be unpacked directly into P and PA images respectively, which Unpack.c doesn't currently support.This PR fixes that.