Merged
Conversation
hugovk
approved these changes
Jun 13, 2023
Member
hugovk
left a comment
There was a problem hiding this comment.
Good to merge, maybe add a Co-authored-by?
Co-authored-by: nulano <nulano@nulano.eu>
Member
Author
|
Ok, I've updated the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting a change from the draft PR #6926
Pillow/src/_imagingft.c
Lines 168 to 170 in 599979c
On first glance, the PR simply stops this value from being hardcoded, by replacing it with
FT_Err_Out_Of_Memory, as per https://freetype.org/freetype2/docs/reference/ft2-error_code_values.html.However, 65 is actually not the out of memory error code. 65 is 0x41, and according to that FreeType doc, 0x40 is "out of memory", while 0x41 is "unlisted object". So this change is not just stylistic, but also corrects the error code.