Conversation
nulano
left a comment
There was a problem hiding this comment.
Is there any reason you sometimes used Py_DECREF instead of Py_XDECREF?
It looks to me like it might be just for PyUnicode_FromString, but I don't see anything special about that function.
|
Just for the times when we know that the value isn't null. Looking at the documentation, I had concluded that |
|
I am pretty sure that is an omission in the documentation: I'd expect every function that can allocate memory to possibly fail and return |
|
Ok, I've pushed an update. |
|
@nulano How does this look now? |
|
I've got one suggestion - I'm working on a PR to open in @radarhere's repo. Edit: see radarhere#19 |
|
Just to be clear, part of @nulano's suggestion is to remove >>> from PIL import _imagingmorph
>>> _imagingmorph.__version
'0.1'It's an unused part of the C API, so no objections. |
Resolves #6323