Skip to content

Do not raise an error if os.environ does not contain PATH#6935

Merged
radarhere merged 2 commits intopython-pillow:mainfrom
radarhere:path
Mar 12, 2023
Merged

Do not raise an error if os.environ does not contain PATH#6935
radarhere merged 2 commits intopython-pillow:mainfrom
radarhere:path

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Feb 9, 2023 •
edited
Loading

Resolves #6934

Pillow/setup.py

Lines 245 to 249 in 7e3bed6

def _cmd_exists(cmd):
return any(
os.access(os.path.join(path, cmd), os.X_OK)
for path in os.environ["PATH"].split(os.pathsep)
)

presumes that os.environ contains a "PATH" key.

This PR changes the code no longer raise an error if it doesn't.

hugovk
hugovk reviewed Mar 12, 2023
View reviewed changes
@radarhere @hugovk
Use type hint
7670736 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk hugovk added the automerge Automatically merge PRs that are ready label Mar 12, 2023
@radarhere radarhere merged commit 5b3d39c into python-pillow:main Mar 12, 2023
@radarhere radarhere deleted the path branch March 12, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Labels

automerge Automatically merge PRs that are ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

setup.py build fails without PATH

2 participants

@radarhere @hugovk