Do not validate for unevaluatedProperties#1075
Merged
Julian merged 3 commits intopython-jsonschema:mainfrom Mar 28, 2023
Merged
Do not validate for unevaluatedProperties#1075Julian merged 3 commits intopython-jsonschema:mainfrom
Julian merged 3 commits intopython-jsonschema:mainfrom
Conversation
Member
|
Nice! Indeed looks like this is a decent (~40%) speedup for the (unevaluatedProperties-specific) microbenchmark that I've been referring to for the new release. Obviously I can believe there's gaps in the precise output for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that without checking
is_validthe test suite still passes. The invalid properties already produce an error, so that the "unevaluated property" error is never needed to achieve a validation failure. On the contrary, when all property validation succeeds, "unevaluated property" could still produce an error.Arguably, producing an error for expected but invalid properties is also confusing, being a "double jeopardy" of validation failures.
📚 Documentation preview 📚: https://python-jsonschema--1075.org.readthedocs.build/en/1075/