Add AttrsInstance protocol to forgotten attrs.asdict and attrs.astuple#1090
Merged
hynek merged 4 commits intopython-attrs:mainfrom Jan 23, 2023
Merged
Add AttrsInstance protocol to forgotten attrs.asdict and attrs.astuple#1090hynek merged 4 commits intopython-attrs:mainfrom
hynek merged 4 commits intopython-attrs:mainfrom
Conversation
Tinche
approved these changes
Jan 22, 2023
Member
|
@tsx ah sorry can you add a news fragment describing the change in one sentence? I'm traveling rn otherwise I would do it myself. Thanks! |
Contributor
Author
|
@hynek done. I tried to make it short and to the point. |
Member
|
Thanks! I've added a clarification that it's just about stubs, so people don't think there's a change in behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1089
AttrsInstanceprotocol was added in #890 but two functions in theattrsnamespace were apparently forgotten and still accept Any as the instance. This PR changes the signatures to acceptAttrsInstanceinstead to match what's in theattrnamespace.Pull Request Check List
Our CI fails if coverage is not 100%.
.pyi).tests/typing_example.py.attr/__init__.pyi, they've also been re-imported inattrs/__init__.pyi.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives.Find the appropriate next version in our
__init__.pyfile..rstfiles is written using semantic newlines.changelog.d.