Fix @frozen exceptions to allow __traceback__ to be set.#1081
Merged
hynek merged 1 commit intopython-attrs:mainfrom Jan 8, 2023
Merged
Conversation
Member
|
Ah nice I'm pretty sure I ran junk this myself when switching to 3.11 but decided to just thaw the class and get on with my life. Can you finish it up with a news fragment pls? |
6e3a7eb to
a604fc2
Compare
Member
Author
|
Fixed! |
hynek
reviewed
Jan 8, 2023
changelog.d/1081.change.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Fix frozen exception classes when raised within e.g. `contextlib.contextmanager`, which mutates their ``__traceback__`` attributes. | |||
Member
There was a problem hiding this comment.
Sir this is a Wendy's Markdown shop. 🤓
E.g. contextlib.contextmanager does so whenever an exception is raised in its body, and does so even on CPython, so merging the two code paths now seems reasonable.
a604fc2 to
388ecab
Compare
nadove-ucsc
added a commit
to DataBiosphere/azul
that referenced
this pull request
Feb 28, 2024
hannes-ucsc
pushed a commit
to DataBiosphere/azul
that referenced
this pull request
Mar 1, 2024
dsotirho-ucsc
pushed a commit
to DataBiosphere/azul
that referenced
this pull request
Mar 1, 2024
hannes-ucsc
pushed a commit
to DataBiosphere/azul
that referenced
this pull request
Mar 2, 2024
dsotirho-ucsc
pushed a commit
to DataBiosphere/azul
that referenced
this pull request
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This code previously raised an
attrs.FrozenInstanceError:on CPython (3.11 specifically, but probably other versions). On PyPy, it works, at least on 3.9 here -- which means I think it seems reasonable to merge the two codepaths here as I've done rather than whitelisting different attributes on different interpreters, but lemme know if you disagree.
(In real life a likely way you're going to encounter this, just to help anyone searching, is that
clickwill wrap all exceptions during execution of a program, and does so via acontextlib.contextmanager)Refs #712
Pull Request Check List
Our CI fails if coverage is not 100%.
.pyi).tests/typing_example.py.attr/__init__.pyi, they've also been re-imported inattrs/__init__.pyi.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives.Find the appropriate next version in our
__init__.pyfile..rstfiles is written using semantic newlines.changelog.d.