Skip to content

Add workflow for Trusted Publishing#395

Merged
JelleZijlstra merged 14 commits intopython:mainfrom
JelleZijlstra:publish
May 16, 2024
Merged

Add workflow for Trusted Publishing#395
JelleZijlstra merged 14 commits intopython:mainfrom
JelleZijlstra:publish

Conversation

@JelleZijlstra
Copy link
Copy Markdown
Member

No description provided.

@JelleZijlstra JelleZijlstra marked this pull request as ready for review May 16, 2024 05:15
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JelleZijlstra
Copy link
Copy Markdown
Member Author

I think this is ready to merge now, if someone wants to approve again.

python -m pip install --user $path_to_file
python -m pip list
- name: Run typing_extensions tests against installed package
run: rm src/typing_extensions.py && python src/test_typing_extensions.py
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea: To make it more robust against future changes, maybe copy the test_* script to /tmp and delete all of src?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not enough because it relies on a few helper files. I think we'll have to change this either way if we ever change our file layout.

python -m pip install --user $path_to_file
python -m pip list
- name: Run typing_extensions tests against installed package
run: rm src/typing_extensions.py && python src/test_typing_extensions.py
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

JelleZijlstra and others added 2 commits May 16, 2024 13:31
@JelleZijlstra JelleZijlstra requested a review from srittau May 16, 2024 17:34
@JelleZijlstra JelleZijlstra merged commit 63d8277 into python:main May 16, 2024
@JelleZijlstra JelleZijlstra deleted the publish branch May 16, 2024 18:58
@JelleZijlstra JelleZijlstra restored the publish branch September 10, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants