Skip to content

Backport CPython PR 105976#252

Merged
JelleZijlstra merged 2 commits intopython:mainfrom
AlexWaygood:subclasshooks
Jun 23, 2023
Merged

Backport CPython PR 105976#252
JelleZijlstra merged 2 commits intopython:mainfrom
AlexWaygood:subclasshooks

Conversation

@AlexWaygood
Copy link
Copy Markdown
Member

Backport of python/cpython#105976

@JelleZijlstra
Copy link
Copy Markdown
Member

Thanks! There's a test failure on 3.12.

Also, let's land this after 4.7.0 final goes out next week?

@AlexWaygood
Copy link
Copy Markdown
Member Author

Also, let's land this after 4.7.0 final goes out next week?

It fixes a regression introduced in the 4.6 series... But I'm happy to defer to your judgement as RM :)

I do appear to have been the only user of typing_extensions.Protocol affected by the regression I introduced 😆

@JelleZijlstra
Copy link
Copy Markdown
Member

Ah you're right, we should fix this in 4.7.0 then.

@JelleZijlstra JelleZijlstra merged commit e65b036 into python:main Jun 23, 2023
@AlexWaygood AlexWaygood deleted the subclasshooks branch June 23, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants