Defer import of json and platform#503
Merged
jaraco merged 6 commits intopython:mainfrom Sep 11, 2024
danielhollas:defer-json
Merged
Defer import of json and platform#503jaraco merged 6 commits intopython:mainfrom danielhollas:defer-json
jaraco merged 6 commits intopython:mainfrom
danielhollas:defer-json
Conversation
danielhollas
commented
Aug 27, 2024
Member
|
Attempting to disentangle the performance impacts of I see |
jaraco
reviewed
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staged on top of #502
platformandjsonmodules take together around 1.5ms to import, around 10% of total import time. Since they are both used in a single place it probably makes sense to inline their import.After this PR, this is an output of
python -Ximporttime -c "import importlib_metadata"visualized with tuna using cpython main branch.