Skip to content

Detecting and handling PDM's symlinked packages#453

Merged
jaraco merged 12 commits intopython:mainfrom
jherland:symlinked-packages-work
Jun 18, 2023
Merged

Detecting and handling PDM's symlinked packages#453
jaraco merged 12 commits intopython:mainfrom
jherland:symlinked-packages-work

Conversation

@jherland
Copy link
Contributor

This is accompanying issue #452: The first commit adds a test case to demonstrate the issue, and the second attempt is a first, rough, attempt at fixing it.

I am unsure if a proper fix should only have _top_level_inferred() recurse/walk into symlinked directories, or if the recurse/walk should also apply to Distribution.files().

Commits:

  • Add test to demonstrate issue with symlinked packages
  • Attempt to fix issue with symlinked packages

@jherland jherland force-pushed the symlinked-packages-work branch from 605fdea to 0023c15 Compare April 19, 2023 09:21
@jaraco
Copy link
Member

jaraco commented Jun 18, 2023

I am unsure if a proper fix should only have _top_level_inferred() recurse/walk into symlinked directories, or if the recurse/walk should also apply to Distribution.files().

My instinct is that Distribution.files() should be naive and return the files for the virtual package as installed and not resolve to the linked content - at least until such a time that linked packages are more formally defined and accepted as a standard in the Python ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants