Skip to content

Fix issue #209#210

Merged
icemac merged 4 commits intopytest-dev:masterfrom
lukasNebr:fix_skip_error_during_teardown
Mar 9, 2023
Merged

Fix issue #209#210
icemac merged 4 commits intopytest-dev:masterfrom
lukasNebr:fix_skip_error_during_teardown

Conversation

@lukasNebr
Copy link
Copy Markdown
Contributor

@lukasNebr lukasNebr commented Feb 20, 2023 •
edited by icemac
Loading

Fixes #209

  • Execute teardown when test is skipped in a setup fixture
  • Execute teardown when setup fails

@lukasNebr lukasNebr mentioned this pull request Feb 20, 2023
Closed
@lukasNebr lukasNebr marked this pull request as ready for review February 25, 2023 20:04
@gopiotr
Copy link
Copy Markdown

gopiotr commented Mar 8, 2023

@icemac @sallner - can you look at this, please? :)

icemac
icemac approved these changes Mar 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@icemac icemac merged commit 5676365 into pytest-dev:master Mar 9, 2023
@icemac
Copy link
Copy Markdown
Contributor

icemac commented Mar 9, 2023

Released as https://pypi.org/project/pytest-rerunfailures/11.1.2/

@gopiotr
Copy link
Copy Markdown

gopiotr commented Mar 9, 2023

Released as https://pypi.org/project/pytest-rerunfailures/11.1.2/

@lukasNebr @icemac thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icemac icemac icemac approved these changes

+1 more reviewer

@gopiotr gopiotr gopiotr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Session teardown not executed when test is skipped in fixture

3 participants

@lukasNebr @gopiotr @icemac