Specify rootdir to recursive pytest calls (fixes #110)#113
Merged
mrbean-bremen merged 1 commit intopytest-dev:mainfrom Apr 2, 2024
Merged
Specify rootdir to recursive pytest calls (fixes #110)#113mrbean-bremen merged 1 commit intopytest-dev:mainfrom
mrbean-bremen merged 1 commit intopytest-dev:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 97.21% 98.29% +1.08%
==========================================
Files 5 5
Lines 575 588 +13
Branches 136 141 +5
==========================================
+ Hits 559 578 +19
+ Misses 9 2 -7
- Partials 7 8 +1 ☔ View full report in Codecov by Sentry. |
Member
mrbean-bremen
left a comment
There was a problem hiding this comment.
Thanks a lot! Can you add an entry in the release notes?
7e2a507 to
995e17c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a discussion on the pytest issue pytest-dev/pytest#11781 the source of #110 has become a little clearer: the
rootdirwas set to/tmp, being the common ancestor of the temporary test directory and the invocation directory in the CI environment. This patch specifies therootdirexplicitly.