[PR #14050/966edc9d backport][9.0.x] Fix: assertrepr_compare respects dict insertion order#14193
Merged
nicoddemus merged 1 commit into9.0.xfrom Feb 14, 2026
Conversation
nicoddemus
approved these changes
Feb 14, 2026
Member
|
@nicoddemus Looking over the changes for 9.0.3, I think this PR is not quite suitable for a patch release. It's not really a bug fix, and not a regression, a relatively big change in behavior. So I am going to revert it from 9.0.x and it will just wait for 9.1.0. |
bluetech
added a commit
to bluetech/pytest
that referenced
this pull request
Apr 7, 2026
…-dev#14050) (pytest-dev#14193)" This reverts commit 60fb59d. Revert 9.0.x backport, will wait for 9.1.0 instead.
Member
|
Agree, thanks for the catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #14050 as merged into main (966edc9).
Closes #13503. Modified SafeRepr to override repr_dict and avoid sorting keys, ensuring that assertion failure messages preserve the user's insertion order for dictionaries.