python: a bit nicer error on duplicate parametrization#13458
Merged
Conversation
Raising `ValueError` dumps all of the internal stacktrace to the user, which is not helpful. Raising `CollectError` is handled specially to just print the message. It would be nice to show source location or such - maybe another time. Fix #13457
RonnyPfannschmidt
approved these changes
Jun 1, 2025
Member
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
Let's log a issue to annoate the details in generate_tests when possible
Like node oder origin and used marker
Pierre-Sassoulas
approved these changes
Jun 2, 2025
Member
Author
I added a commit which pinpoints the node ID at least for now (also for another parametrization error), as it's easy. Not sure it's worth bothering with something more elaborate. |
nicoddemus
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raising
ValueErrordumps all of the internal stacktrace to the user, which is not helpful. RaisingCollectErroris handled specially to just print the message.It would be nice to show source location or such - maybe another time.
Fix #13457