👷 ci(brew): add missing Homebrew Python versions and fix discovery#3066
Merged
Conversation
cedc5e5 to
e86ce0f
Compare
e86ce0f to
a733102
Compare
The gh CLI requires authentication via GH_TOKEN to access the GitHub API in Actions workflows. Without it the nushell release download fails with exit code 4 on all Windows matrix entries.
The chocolatey nushell package installation is unreliable due to CDN timeouts. The gh release download approach works but GITHUB_PATH additions don't propagate into tox test environments. Copying nu.exe directly to the chocolatey bin directory (already on system PATH) ensures the nushell activation tests can find the binary.
The nushell release zip extracts files flat (no subdirectory), so nu.exe is directly under the extraction output directory.
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS CI matrix only tested Homebrew-installed Python 3.9 through 3.11, but Homebrew now ships
python@3.12,python@3.13, andpython@3.14. This gap means virtualenv's Homebrew-specific code path (CPython3macOsBrew) wasn't being validated against the versions most users actually install today.Additionally, the existing brew jobs were broken — they set
TOX_DISCOVERto point at the brew interpreter, buttox-uvignores that variable entirely. The tox test environments were silently using theactions/setup-pythoninterpreter instead of the brew one, defeating the purpose of these matrix entries. 🔧 Switching toUV_PYTHONensurestox-uvactually creates the test environment with the Homebrew Python.