🧪 test(discovery): fix test_py_info_cache_clear outside venv#3065
Merged
Conversation
The test assumed a fixed relationship between _run_subprocess call counts across both from_exe invocations, which breaks when running outside a virtual environment (e.g. Fedora RPM builds) where _resolve_to_system doesn't trigger additional subprocess calls. Restructured to match the pattern used in the already-fixed sibling test_py_info_cache_invalidation_on_py_info_change: set up the spy after cache clearing, and account for the venv vs non-venv difference using native_difference. Fixes pypa#2939
0456359 to
6876203
Compare
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_py_info_cache_clearfails when tests run outside a virtual environment (e.g. Fedora RPMbuilds, reported in #2939). The test tracked cumulative
_run_subprocessspy counts across twofrom_execalls and assumed a2 * countrelationship, which breaks when_resolve_to_systemdoesn't trigger additional subprocess calls — the case when
system_executable == executable.Restructured to follow the same pattern as the already-fixed sibling
test_py_info_cache_invalidation_on_py_info_change: set up the spy only after clearing the cache,and account for the venv vs non-venv difference using
native_difference. This makes the assertionindependent of how many subprocess calls the initial cache-warming
from_exetriggers. 🐛Fixes #2939