Fix debug logging interpolation#2849
Merged
gaborbernat merged 1 commit intopypa:mainfrom Feb 25, 2025
Merged
Conversation
Previously, message and args would each get interpolated separately,
with a result like
wrote python info of %s at (PosixPath('/usr/bin/python3.12'),
PosixPath('/home/...f265.json')) [DEBUG via_disk_folder:153]
Now, remove the formatting placeholder from the message passed by
concrete classes. msg then becomes unnecessary; pass it in as part
of msg_args. The result is more like
wrote python info of /usr/bin/python3.12 at /home/...f265.json
[DEBUG via_disk_folder:153]
gaborbernat
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, message and args would each get interpolated separately, with a result like
Now, remove the formatting placeholder from the message passed by concrete classes. msg then becomes unnecessary; pass it in as part of msg_args. The result is more like
Sorry; previously was #2848 but I accidentally closed it.
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder