Skip to content

fix: Update run_with_catch log flushing#2806

Merged
gaborbernat merged 1 commit intopypa:mainfrom
neilramsay:bugfix/logger-flush
Nov 26, 2024
Merged

fix: Update run_with_catch log flushing#2806
gaborbernat merged 1 commit intopypa:mainfrom
neilramsay:bugfix/logger-flush

Conversation

@neilramsay
Copy link
Copy Markdown
Contributor

run_with_catch is flushing the Python standard library logger prior to any traces are printed.

It appears the function logger.shutdown() does not work. Instead each logger handler stream should be flushed individually.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

run_with_catch is flushing the Python standard
library logger prior to any traces are printed.

It appears the function logger.shutdown() does not work.
Instead each logger handler stream should be flushed individually.
@gaborbernat gaborbernat merged commit d619967 into pypa:main Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants