Fix broken Windows zipapp and drop 3.7 support#2783
Merged
gaborbernat merged 2 commits intopypa:mainfrom Oct 18, 2024
Merged
Conversation
b51e05f to
6eaa3c2
Compare
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
fa88900 to
393bdd3
Compare
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
|
Not sure it was expected, but this change also breaks making a 3.7 venv, not just running on 3.7. Seen in pypa/pyproject-metadata#207; nox can no longer target 3.7. |
Contributor
Author
|
That is very much expected. tox does https://tox.wiki/en/4.23.0/faq.html#testing-end-of-life-python-versions NOx should do similar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves pypa/distlib#235
Resolves #2784
Both change sets are needed to make the CI pass.