Conversation
Since Python 3.7, ``dict`` preserve insertion order. This means that ``dict`` is a capable implementation of an ordered set, despite the method names not lining up completely.
Contributor
|
Searching for "ordered" in python files, there's a few bits of logic that still assume dicts are unordered. It's getting late here, but I could open a PR in parallel of yours with all those I found. |
Avasam
reviewed
Aug 17, 2024
| @@ -188,7 +188,7 @@ def test_read_metadata(name, attrs): | |||
| ('requires', dist_class.get_requires), | |||
Contributor
There was a problem hiding this comment.
Line 313 still contains a reference to "ordered-set==3.1.1" (it's in an example, but may as well remove it)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is a follow up of the discussion on #4457 (review).
Since Python 3.7,
dictpreserve insertion order.This means that
dictis a capable implementation of an ordered set,despite the method names not lining up completely.
We can effectively use
dictto obtain the same functionality that would be implemented byordered_setand therefore we can remove the extra dependency.Closes
Pull Request Checklist
newsfragments/.(See documentation for details)
Optionally, we could have something like
But that would be mostly cosmetic, since we can simply use the
dictmethods directly and obtain the same effects...