Use --force-reinstall in integration test and skip wheel#4565
Merged
abravalheri merged 2 commits intomainfrom Aug 13, 2024
Merged
Use --force-reinstall in integration test and skip wheel#4565abravalheri merged 2 commits intomainfrom
--force-reinstall in integration test and skip wheel#4565abravalheri merged 2 commits intomainfrom
Conversation
--force-reinstall in integration test and skip wheel
Contributor
Author
|
Integration tests should run in https://github.com/pypa/setuptools/actions/runs/10369805360, so we can see if this fixes the problem or not. |
Contributor
Author
|
Integration tests pass after the changes: https://github.com/pypa/setuptools/actions/runs/10369805360/job/28707136245. |
Member
|
I re-ran the failed jobs for v72.2.0, since the release didn't go out as planned, and it succeeded. |
Member
|
Because the issue is intermittent, we'll want to keep an eye out to see if it happens again. Presumably this change will fix the issue. Thanks for working on it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
In integration test:
pip install -Iwithpip install --force-reinstallwheelas it is no longer a build dependency (it also no longer gets automatically installed in the build env in regular workflows).Closes #4564
Pull Request Checklist
newsfragments/.(See documentation for details)