Changed the import of ctypes.wintypes from __import__ to a regular import statement#4534
Merged
abravalheri merged 2 commits intopypa:mainfrom Aug 8, 2024
Merged
Conversation
…gular ``import`` statement
2a76142 to
80d391c
Compare
Contributor
|
Thank you @Avasam. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
The issue python/cpython#61140 referenced in 1fab75a, has been resolved in Python 3.8.7 https://docs.python.org/3.8/whatsnew/changelog.html#python-3-8-7-release-candidate-1
Even then, the decoractor added in 81b4d92 ensures that this wouldn't be run on non-windows machines anyway.
Resolves a few mypy
attr-definedand pyrightreportAttributeAccessIssuefor #2345Pull Request Checklist
newsfragments/.(See documentation for details)