Skip to content

Add --all-shells flag to ensure_path#1591

Merged
dukecat0 merged 1 commit intopypa:mainfrom
gh271:main
Jan 10, 2025
Merged

Add --all-shells flag to ensure_path#1591
dukecat0 merged 1 commit intopypa:mainfrom
gh271:main

Conversation

@gh271
Copy link
Copy Markdown

@gh271 gh271 commented Jan 2, 2025

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Add --all-shells flag to pipx ensure_path, see issue: #1585

Test plan

Tested by running:

$ pipx ensurepath --all-shells

I have one failing test (test_run_with_requirements):

ERROR    pipx.util:util.py:347 Fatal error from pip prevented installation. Full pip output in file:

The pip output file contains:

PIP STDOUT
----------
Looking in indexes: http://127.0.0.1:62640/simple/

PIP STDERR
----------
ERROR: Could not find a version that satisfies the requirement requests==2.31.0 (from versions: 2.32.3)
ERROR: No matching distribution found for requests==2.31.0

Unfortunately I don't know what is causing this or how I can fix it, any ideas?

dukecat0
dukecat0 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dukecat0 dukecat0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@dukecat0 dukecat0 merged commit ecbab56 into pypa:main Jan 10, 2025
@WilliamDEdwards
Copy link
Copy Markdown

WilliamDEdwards commented Sep 4, 2025

@dukecat0 @Gitznik When are you planning to cut a new pipx release? It's been over a year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gitznik Gitznik Gitznik approved these changes

@dukecat0 dukecat0 dukecat0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gh271 @WilliamDEdwards @Gitznik @dukecat0 @uu7x