Replace spaces in platform names with underscores#620
Conversation
46179b8 to
8297153
Compare
|
@brettcannon done! |
8297153 to
9f42a87
Compare
|
I just realized there's no issue associated with this PR, so folks don't know there's a decision to be made here. @tucked would you mind creating an issue? |
|
@tucked I'm ready to review this again, but I still need an issue to be created so I can discuss this with the other maintainer to make sure this isn't going to be a breaking change in some way that I can't think of. |
|
Hey @brettcannon, thanks for getting back to me and sorry for the delay. I've been out for the holidays. I've created #652 and linked this PR to it! I've also rebased this PR onto the latest |
|
It looks like a new test was added recently which breaks with this change: Lines 845 to 848 in 2067970 I suppose that suggests that we may only want to normalize spaces in packaging/src/packaging/tags.py Lines 483 to 496 in 2067970 |
eeea378 to
e7f14b3
Compare
Not necessarily. It's something we can discuss as to what's best to do. |
👌 Good to know.... I already made the adjustment from the previous diff, but we can always switch back if that ends up being the best route. |
e7f14b3 to
f510a94
Compare
|
Based on Matti's response in #652, I've switched back to the original diff and patched the new test. |
f510a94 to
b263edc
Compare
|
@tucked Thanks! |
Resolve #652