Skip to content

Add DIST_EXTRA_CONFIG option for passing setup.cfg overrides during build#177

Merged
jaraco merged 7 commits intopypa:mainfrom
zooba:extra-config
Sep 24, 2022
Merged

Add DIST_EXTRA_CONFIG option for passing setup.cfg overrides during build#177
jaraco merged 7 commits intopypa:mainfrom
zooba:extra-config

Conversation

@zooba
Copy link
Copy Markdown
Contributor

@zooba zooba commented Sep 1, 2022

As discussed during pypa/cibuildwheel#1144

@zooba
Copy link
Copy Markdown
Contributor Author

zooba commented Sep 1, 2022

Haven't done all my own testing yet - wanted to get the change up for discussion first.

@zooba
Copy link
Copy Markdown
Contributor Author

zooba commented Sep 1, 2022

I have now tested this as part of the cibuildwheel tests (thanks to simpleindex :-) )

@zooba
Copy link
Copy Markdown
Contributor Author

zooba commented Sep 13, 2022

@jaraco This is what we started discussing in pypa/cibuildwheel#1144

@zooba
Copy link
Copy Markdown
Contributor Author

zooba commented Sep 21, 2022

@jaraco Ping again.

@jaraco jaraco self-assigned this Sep 24, 2022
@jaraco jaraco changed the title Add DISTUTILS_EXTRA_CONFIG option for passing setup.cfg overrides during build Add DIST_EXTRA_CONFIG option for passing setup.cfg overrides during build Sep 24, 2022
@jaraco
Copy link
Copy Markdown
Member

jaraco commented Sep 24, 2022

I decided to go with DIST_EXTRA_CONFIG to decouple from the implementation.

@jaraco jaraco merged commit 0d022d6 into pypa:main Sep 24, 2022
@jaraco
Copy link
Copy Markdown
Member

jaraco commented Sep 24, 2022

This change is going out with Setuptools 65.4.0, slated to be on PyPI soon. Please take a look.

@zooba zooba deleted the extra-config branch September 26, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants