chore: avoid template injection zizmor issue#994
Conversation
|
By the way, I'm not fond of the release note system using files and PR numbers, because you don't know the PR number till after you make the PR, and you have to repeat yourself in the description and the changelog, at least a little. And you don't have final say in how the end result is polished. In pybind11, I have a system that pulls from a special block in the PR description, and the final result is polished by hand (and edits happen in the PRs, meaning those get cleaned up too). The conventional commit title of the PR helps place the category, too. |
Generally that happens rarely, often you should have the issue. And when you do have that you can always force push and update. |
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
a3cdbc9 to
4aef1a1
Compare
|
We don't have an internal/ci category, so this doesn't need one, I assume? |
|
Formatting on the PR template is off, there's a double tick mark left over. Wow, that's hard to get rid of. I can do with with an extra space: Example: |
Description
Followup to #991.
Changelog
docs/changelog/<pr_number>.<type>.rstfeature,bugfix,doc,removal,misc123.feature.rstcontainingAdd custom backend support - by :user:yourname``Checklist
tox)tox -e fix)tox -e type)tox -e docs)