fix: api should not ignore installed, only CLI#1056
Conversation
Signed-off-by: Henry Schreiner <henryfs@princeton.edu> Assisted-by: Copilot:GPT-5.4
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
|
A few points to consider in review:
|
|
I'm alright to release a new version without backporting, personally. |
|
I'm not sure about this. I would prefer to drop |
|
This does drop How about we make this parameter private for now, and only make it public if someone needs it? That gives us the ability to solve this another way in the future, while still fixing pyodide and keeping previous fix (which seems to be working, at least no one has complained). |
That's a good idea - let's do it that way. |
Assisted-by: OpenCode:qwen3.6:27b-coding-nvfp4 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Description
Our recent change broke pyodide-build, which is manually using our API and pre-installing some dependencies that are patched for pyodide. This is a proposed fix, which keeps the API explicit (users need to opt-in with
fresh=True), but our CLI opts into it.When asking copilot CLI to do the fix, it also suggested
--reinstallfor uv to match pip's behavior. I haven't worked out yet if that's the best thing here, but that might not hurt to have.🤖 Assisted-by: Copilot:GPT-5.4
Changelog
docs/changelog/<pr_number>.<type>.rstfeature,bugfix,doc,removal,misc123.feature.rstcontainingAdd custom backend support - by :user:`yourname`Checklist
tox)tox -e fix)tox -e type)tox -e docs)