feat: drop 3.9, require 3.10+#1036
Merged
Merged
Conversation
gaborbernat
approved these changes
Apr 13, 2026
layday
requested changes
Apr 13, 2026
Contributor
Author
|
I'm going to put this in draft until the question on the direct url PR gets resolved - if we need a patch release, it's a bit easier if this isn't in yet. ;) (Addressing review soon). |
Contributor
Author
|
I added the banned API to Ruff, and verified that telling copilot gpt-5-mini to run and fix I like being able to turn nearly any check report into an autofix. :) |
henryiii
commented
Apr 13, 2026
layday
reviewed
Apr 18, 2026
Member
|
A couple of < 3.10 constraints in tests/constraints.txt can also go. |
* require >=3.10, update docs/tests, and fix ruff UP007 in _types.py * Respect ruff banned-api: use local TYPE_CHECKING variable and keep union | syntax (fix ruff TID251) Assisted-by: Copilot:gpt-5-mini
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Removed print statement for None case in log function.
Co-authored-by: layday <layday@protonmail.com>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
b50427f to
ccc2acd
Compare
ccc2acd to
1108d62
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
gaborbernat
reviewed
Apr 23, 2026
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
gaborbernat
approved these changes
Apr 23, 2026
gaborbernat
left a comment
Collaborator
There was a problem hiding this comment.
Not sure if the match over the if is better but I'm not against it.
layday
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pip is about to drop 3.9, so we probably can too. I don't think there are any pressing fixes we need to get out for 3.9.
🤖 Used Copilot:gpt-5-mini for the first commit.
Changelog
docs/changelog/<pr_number>.<type>.rstfeature,bugfix,doc,removal,misc123.feature.rstcontainingAdd custom backend support - by :user:`yourname`Checklist
tox)tox -e fix)tox -e type)tox -e docs)