chore: add ruff PYI#1026
Merged
Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
gaborbernat
approved these changes
Apr 10, 2026
layday
reviewed
Apr 13, 2026
| if TYPE_CHECKING: | ||
| from collections.abc import Iterator, Set | ||
| from collections.abc import Iterator | ||
| from collections.abc import Set as AbstractSet |
Contributor
Author
There was a problem hiding this comment.
It's a ruff rule to keep it from looking like dict/Dict or list/List, which are the same thing, but just typing versions. While Set is not a set, it's an immutable set-like ABC. frozenset is also a valid Set. It's more like Sequence, etc.
Not my favorite rule (as Dict/List and similar classes become less common, it's less important), but it's fine. (BTW, let me know if you know another name vs. AbstractSet, this is just the suggestion).
Member
There was a problem hiding this comment.
Ah, I didn't realise this was part of the ruleset. That's fair enough then, let's leave it be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding the PYI check.