🐛 fix(deps): add pre-commit to release dependency group#1000
Merged
gaborbernat merged 1 commit intopypa:mainfrom Mar 24, 2026
Merged
🐛 fix(deps): add pre-commit to release dependency group#1000gaborbernat merged 1 commit intopypa:mainfrom
gaborbernat merged 1 commit intopypa:mainfrom
Conversation
The release.py script calls pre-commit on lines 70 and 72 to format and lint the generated release commit. Without pre-commit in the release dependency group, the workflow fails with FileNotFoundError when tox runs the release environment. Added pre-commit >= 3.0 to match the version used in the docs dependency group, ensuring the release script can run formatting hooks on the generated changelog and version updates.
henryiii
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-release workflow fails at run 23515770142 because the release script calls
pre-committo format and lint the generated release commit, butpre-commitis not installed in the release tox environment. 🔧 The script invokespre-commit run --all-fileson lines 70 and 72 oftasks/release.py, resulting in aFileNotFoundErrorwhen the command cannot be found.Added
pre-commit >= 3.0to the release dependency group inpyproject.toml. This matches the version constraint used in the docs dependency group and ensures the release script can run formatting hooks on the generated changelog and version updates.Without this dependency, the release workflow cannot complete successfully. With it, the pre-commit hooks will properly format the release commit before it gets tagged and pushed.