make datetime from timestamp tests compare against Python result#4275
Merged
davidhewitt merged 4 commits intoPyO3:mainfrom Jun 23, 2024
Merged
make datetime from timestamp tests compare against Python result#4275davidhewitt merged 4 commits intoPyO3:mainfrom
davidhewitt merged 4 commits intoPyO3:mainfrom
Conversation
Member
Author
|
As a test adjustment, will proceed to merge this now without waiting for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off #4212, includes the commits from @Cheukting
The observation is that I believe these tests are trying to verify the Rust behaviour (via the
datetimebindings in PyO3) matches the Python behaviour.So if the call throws, it doesn't matter, as long as the Python call would also throw.
Closes #4212
Closes #3922