Fix missing __dict__#2685
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 93 93
Lines 11066 11069 +3
=======================================
+ Hits 10313 10316 +3
Misses 753 753
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
DanielNoord
left a comment
There was a problem hiding this comment.
Do you mind adding a test for this?
Possibly by calling del on something with a __dict__ attribute.
199ce1c to
ce259c0
Compare
|
I just added a test but with the mypy exception because it's not possible to delete the dict attribute on an exception! |
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
LGTM thank you for opening the issue and following up @sbrunner !
ce259c0 to
b912202
Compare
|
When is it planned to be merged and released? |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-2685-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eed745859f1242e300de597e5050433e62adcbfe
# Push it to GitHub
git push --set-upstream origin backport-2685-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.xThen, create a pull request where the |
|
Thanks for the reminder @sbrunner ! We'll backport and release in the next patch version |
|
Excellent, thanks @Pierre-Sassoulas :-) |
|
Maybe only in 4.0.0 as the cherry-pick is a little tricky #2690 . |
Type of Changes
Description
No crash when the object didn't have an attribute
__dict__Refs pylint-dev/pylint#10223