Skip flaky recursion test on PyPy#2661
Merged
jacobtylerwalls merged 1 commit intomainfrom Dec 21, 2024
Merged
Conversation
Follow-up to 03cd54c.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2661 +/- ##
=======================================
Coverage 93.21% 93.21%
=======================================
Files 93 93
Lines 11083 11083
=======================================
Hits 10331 10331
Misses 752 752
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Pierre-Sassoulas
approved these changes
Dec 21, 2024
Member
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Strongly agree with this decision
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-2661-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 30ddb250a4c15aadf5d397fa42a96a2ac108c8d8
# Push it to GitHub
git push --set-upstream origin backport-2661-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.xThen, create a pull request where the |
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Dec 22, 2024
jacobtylerwalls
added a commit
that referenced
this pull request
Dec 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 03cd54c.
No one has the time or inclination to find a stable recursion limit that is low enough to reliably trigger the UserWarning without actually causing core dumps or other problems, esp. when running with coverage.