speedup: cache entry points#2979
Merged
birkenfeld merged 1 commit intopygments:masterfrom Feb 20, 2026
Merged
Conversation
Member
|
That's a very good idea IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that multiple calls to
get_lexer_for_filenamewere somewhat slow in my environment, due tofind_plugin_lexersdiscovering entry points every time it ran.Its interesting that pkg_resources (used in the past) seems to cache entry points: https://github.com/pypa/pkg_resources/blob/main/__init__.py#L3212 But importlib.metadata does not.
I did some simple testing like this:
On my system I got these timings:
It seems to me that adding this caching would not be a problem if pkg_resources cached entry points in the past. I'm not sure how someone would modify entry points at runtime anyway.