Merged
Conversation
…expected builtin token type Comment.Single.
…r codeblock context pygments#2940 .
…e punctuation not text.
frasercrmck
approved these changes
Sep 26, 2025
Contributor
frasercrmck
left a comment
There was a problem hiding this comment.
Thank you, sorry about that.
Contributor
|
@frasercrmck No worries! 👍 |
Contributor
Author
|
@frasercrmck Hey - just pinging this issue again, because this fix impacts developers. Is there another maintainer we can request to review this PR to get merged? |
Contributor
I'm not sure, sorry. I'm not a maintainer here and don't know the protocol. |
Contributor
Author
|
@Anteru I think you might be one of the current active maintainers of this repo? |
Member
|
LGTM, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #2940. The TableGenLexer can hit an infinite loop within the
codeblockcontext.I also update the incorrect token Comment.SingleLine -> Comment.Single, using what is standard across pygments.