Merged
Conversation
Google has a dialect of SQL known as GoogleSQL (formerly ZetaSQL), used in BigQuery and other products. It is documented at https://cloud.google.com/bigquery/googlesql. This adds a GoogleSQL lexer. Resolves pygments#2814.
Contributor
|
I see tests are missing, could you add some? These are the instructions: https://pygments.org/docs/lexerdevelopment/#how-to-test-your-lexer |
Contributor
Author
Done! The test is minimal, but the primary difference in GoogleSQL is a bunch of new keywords (functions), and the golden looks good for those. Thanks. |
Contributor
|
Nice, thanks for being so quick! LGTM 👍 |
Contributor
Author
Thank you too. I don't know what your standards/process is for merging, but if you can merge, I have a couple followup PRs that clean up and improve sql.py, but they will definitely cause conflicts with this one so I'm waiting until after merge. |
Collaborator
|
Merged for 2.19, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google has a dialect of SQL known as GoogleSQL (formerly ZetaSQL), used in BigQuery and other products. It is documented at https://cloud.google.com/bigquery/googlesql.
Resolves #2814.