Merged
Conversation
This commit adds a basic lexer for LLVM's TableGen DSL[1][2]. The major design decision is about how to tokenize "code blocks" since those are, at a TableGen language level, string literals. In practice, however, in LLVM 99% of the time they are snippets of C++ which are processed by a TableGen backend. This would ideally be a configurable property of the lexer. For the initial implementation, it is assumed that code blocks contain C++ code and so the CppLexer is invoked on their contents. [1] https://llvm.org/docs/TableGen/index.html [2] https://llvm.org/docs/TableGen/ProgRef.html
Contributor
Author
|
Some example output:
|
|
Just want to add that this will be a great addition, as we are currently adding a lot of TableGen code blocks to our sphinx project! |
Collaborator
|
I'm sure everyone working on LLVM will appreciate it, merged for 2.19, thanks! |
This was referenced Sep 25, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a basic lexer for LLVM's TableGen DSL[1][2].
The major design decision is about how to tokenize "code blocks" since those are, at a TableGen language level, string literals. In practice, however, in LLVM 99% of the time they are snippets of C++ which are processed by a TableGen backend. This would ideally be a configurable property of the lexer. For the initial implementation, it is assumed that code blocks contain C++ code and so the CppLexer is invoked on their contents.
[1] https://llvm.org/docs/TableGen/index.html
[2] https://llvm.org/docs/TableGen/ProgRef.html