Fixed issue with single-line comments in TransactSqlLexer#2717
Merged
Anteru merged 2 commits intopygments:masterfrom Aug 9, 2024
Merged
Fixed issue with single-line comments in TransactSqlLexer#2717Anteru merged 2 commits intopygments:masterfrom
Anteru merged 2 commits intopygments:masterfrom
Conversation
Collaborator
|
Can you please add the snippet there as an example snippet? |
Contributor
Author
|
Hi @Anteru, Absolutely. I have added a Additionally, I noticed that tests were failing due to single-line comments in Please let me know if any additional action is required of me. Thanks! |
Collaborator
|
No, this looks good. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the regex for the
Comment.Singletoken type in theTransactSqlLexerclass.In the current version of
pygments(2.18.0), the existing regex causes single-line comments to be lexed incorrectly whenever they are immediately followed by a non-comment token on the next line. For example, consider the following code:When run, this results in the following stream of tokens: (Note that the comment is lexed as various other tokens)
Lexing with the modified regex for the token
Comment.Singlein this commit results in the following stream of tokens: (Note that the comment is now lexed correctly.)