Merged
Conversation
jeanas
requested changes
Nov 5, 2023
Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr>
Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr>
Contributor
Author
|
I've made the suggested changes. Let me know if you want me to squash any commits. |
Contributor
|
@Iain-S I've pushed a commit, mostly to make the code style more like the rest of the code base (note that we do not use Black). I've also noticed that this state: "multi_string": [
(r"[^`]+", String),
(r"```", String, "#pop"),
],does not allow single backticks inside |
Contributor
Author
True, that was an oversight. I've added your suggested tuple and a test to confirm that it works. |
Contributor
|
LGTM now, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add lexer for Kusto.
Also corrects a minor typo in the docs.
Checks
toxtests passtox -e mapfilesLinting
Closes
This (hopefully) closes #2098
Further Work \ Known Limitations
1e5, which we don't currently support.datetime(2015-12-31)should all be treated as a single literal but we simply markdatetimeas a keyword.horHbut we ignore this and would treath/Has a name.