Fix GithubIntegration that uses expiring jwt#2460
Merged
EnricoMi merged 1 commit intoPyGithub:masterfrom May 5, 2023
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2460 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 117 117
Lines 11674 11674
=======================================
Hits 11531 11531
Misses 143 143
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
@s-t-e-v-e-n-k can you please approve? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #1986 substantially rewrote
GithubIntegration, which lost using a fresh jwt token when callingget_access_token. This reverts that change.Fixes #2431.
This does not fix expiring JWT tokens when iterating over pages returned by
get_installations(), or callingget_repos()on returnedInstallations. This will require a bigger rework.