Skip to content

Remove RLock from Requester#2446

Merged
s-t-e-v-e-n-k merged 1 commit intoPyGithub:masterfrom
EnricoMi:remove-rlock
Mar 14, 2023
Merged

Remove RLock from Requester#2446
s-t-e-v-e-n-k merged 1 commit intoPyGithub:masterfrom
EnricoMi:remove-rlock

Conversation

@EnricoMi
Copy link
Collaborator

@EnricoMi EnricoMi commented Mar 5, 2023 •
edited
Loading

Each process is refreshing its own copy of the token individually, with or without lock.

Fixes #2436.
Fixes #2430.

This was referenced Mar 5, 2023
Closed
Closed
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (def5223) 98.77% compared to head (15e7096) 98.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2446      +/-   ##
==========================================
- Coverage   98.77%   98.77%   -0.01%     
==========================================
  Files         117      117              
  Lines       11674    11671       -3     
==========================================
- Hits        11531    11528       -3     
  Misses        143      143
Impacted Files Coverage Δ
github/Requester.py 97.41% <50.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@s-t-e-v-e-n-k
Copy link
Collaborator

s-t-e-v-e-n-k commented Mar 6, 2023

You need the Fixes in the commit body for GitHub to automatically close the issues, once that's done we can merge this.

@EnricoMi
Copy link
Collaborator Author

EnricoMi commented Mar 6, 2023

You need the Fixes in the commit body for GitHub to automatically close the issues, once that's done we can merge this.

The "Fixes" in the pull request description do as well.

@reconman
Copy link

reconman commented Mar 6, 2023

The "Fixes" in the pull request description do as well.

Can confirm, Github even says so on the right side of the PR:
image

@s-t-e-v-e-n-k
Copy link
Collaborator

s-t-e-v-e-n-k commented Mar 14, 2023

I will admit I've been waiting for @dblanchette to chime in here, but let's move on.

@s-t-e-v-e-n-k s-t-e-v-e-n-k merged commit 45f3d72 into PyGithub:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-t-e-v-e-n-k s-t-e-v-e-n-k s-t-e-v-e-n-k approved these changes

+1 more reviewer

@justdoit176 justdoit176 justdoit176 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GithubObjects are no longer serializable with pickle 1.58 is not compatible with AWS Lambda

5 participants

@EnricoMi @codecov-commenter @s-t-e-v-e-n-k @reconman @justdoit176