Add support for workflow jobs and steps#1951
Add support for workflow jobs and steps#1951sfdye merged 4 commits intoPyGithub:masterfrom Tenzer:workflow-job-and-steps
Conversation
s-t-e-v-e-n-k
left a comment
There was a problem hiding this comment.
Broadly this is looking good, just missing the type information (pyi files)
|
Thanks for taking a look at this. I have added the missing type annotations now. |
|
Is there any update to this? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Is there any chance this could be incorporated? |
|
Why is this PR closed ? |
|
Is there any chance this feature could be added? I don't see WorkflowJob in this package currently. |
|
@sfdye I don't know if you have seen this PR, but is it possible it could be re-opened and merged? |
|
We need to resolve the merge conflicts |
|
They have been sorted out now. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1951 +/- ##
==========================================
+ Coverage 98.41% 98.68% +0.26%
==========================================
Files 128 119 -9
Lines 12814 11835 -979
==========================================
- Hits 12611 11679 -932
+ Misses 203 156 -47
☔ View full report in Codecov by Sentry. |
|
can't wait it to be released |
|
Thanks for building this @Tenzer. Is there any estimate about when this will be merged/released? |
|
@Tenzer I have added replay data for the logs_url call (and updated the other WorkflowJobs calls). |
davejames
left a comment
There was a problem hiding this comment.
I've done some functional testing on this and am currently using it. LGTM and hope it's merged soon
|
When will this be merged? |
EnricoMi
left a comment
There was a problem hiding this comment.
Happy to approve once these suggestions are incorporated.
This also surfaced an outdated doctype for the `jobs()` method which was corrected.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This relates to GitHub Actions and #1373.
These new features expose information about the jobs run for a workflow, and each of the steps in those jobs.
I also made a small fix to the
add_attribute.pyscript, as it added assertions that didn't work with datetime objects. I think it may have been leftover from the Python 2 support. Disabling the assertion instead made it work and also made the generated code match what I could see was used elsewhere in the project.Please let me know if there's anything missing or any adjustments that need to be made.